lkml.org 
[lkml]   [2012]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RESEND PATCH 1/2] MFD: MAX77693: add MAX77693 MFD driver
From
Hi,

It's discussed previous time. It's PMIC and very sensitive to system.
So we decide to use legacy way. As regmap is not yet tested. So we
summit the current way and revise it later.

Thank you,
Kyungmin Park

On 3/13/12, Venu Byravarasu <vbyravarasu@nvidia.com> wrote:
> Why don't you make use of regmap for all i2c read/ write operations?
>
>> +int max77693_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest)
>> +{
>> + struct max77693_dev *max77693 = i2c_get_clientdata(i2c);
>> + int ret;
>> +
>> + mutex_lock(&max77693->iolock);
>> + ret = i2c_smbus_read_byte_data(i2c, reg);
>> + mutex_unlock(&max77693->iolock);
>> + if (ret < 0)
>> + return ret;
>> +
>> + ret &= 0xff;
>> + *dest = ret;
>> + return 0;
>> +}
>> +EXPORT_SYMBOL_GPL(max77693_read_reg);
>> +
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


\
 
 \ /
  Last update: 2012-03-13 06:41    [W:0.355 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site