lkml.org 
[lkml]   [2012]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND PATCH v2 1/2] MFD: MAX77693: add MAX77693 MFD driver
    Hi Samuel,

    On 05/11/2012 11:15 PM, Samuel Ortiz wrote:

    > Hi Choi,
    >
    > On Tue, Mar 20, 2012 at 10:07:58AM +0900, Chanwoo Choi wrote:
    >> @@ -0,0 +1,224 @@
    >> +/*
    >> + * max77693.c - mfd core driver for the MAX 77693
    >> + *
    >> + * Copyright (C) 2011 Samsung Electronics
    > 2012 ?

    I fix it.

    >
    >> +int max77693_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest)
    >> +{
    >> + struct max77693_dev *max77693 = i2c_get_clientdata(i2c);
    >> + int ret;
    >> +
    >> + mutex_lock(&max77693->iolock);
    >> + ret = i2c_smbus_read_byte_data(i2c, reg);
    >> + mutex_unlock(&max77693->iolock);
    > You don't need this locking as the i2c layer will do it for you.
    > Also, this definitely look like a good candidate for a regmap API conversion,
    > I'd appreciate if you could work on that.
    >

    OK, I will apply regmap for i2c of MAX77693 and post new patchset.

    >> +static struct i2c_driver max77693_i2c_driver = {
    >> + .driver = {
    >> + .name = "max77693",
    >> + .owner = THIS_MODULE,
    >> + },
    >> + .probe = max77693_i2c_probe,
    >> + .remove = max77693_i2c_remove,
    >> + .id_table = max77693_i2c_id,
    >> +};
    >> +
    >> +static int __init max77693_i2c_init(void)
    >> +{
    >> + return i2c_add_driver(&max77693_i2c_driver);
    >> +}
    >> +/* init early so consumer devices can complete system boot */
    >> +subsys_initcall(max77693_i2c_init);
    >> +
    >> +static void __exit max77693_i2c_exit(void)
    >> +{
    >> + i2c_del_driver(&max77693_i2c_driver);
    >> +}
    >> +module_exit(max77693_i2c_exit);
    > You could use module_i2c_driver() here.


    As Mark Brown said, I maintain it.

    Thank you,

    Best Regards,
    Chanwoo Choi




    \
     
     \ /
      Last update: 2012-05-14 07:41    [W:0.032 / U:60.776 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site