lkml.org 
[lkml]   [2012]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [RESEND PATCH 1/2] MFD: MAX77693: add MAX77693 MFD driver
Why don't you make use of regmap for all i2c read/ write operations?

> +int max77693_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest)
> +{
> + struct max77693_dev *max77693 = i2c_get_clientdata(i2c);
> + int ret;
> +
> + mutex_lock(&max77693->iolock);
> + ret = i2c_smbus_read_byte_data(i2c, reg);
> + mutex_unlock(&max77693->iolock);
> + if (ret < 0)
> + return ret;
> +
> + ret &= 0xff;
> + *dest = ret;
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(max77693_read_reg);
> +


\
 
 \ /
  Last update: 2012-03-13 06:37    [from the cache]
©2003-2011 Jasper Spaans