lkml.org 
[lkml]   [2012]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN_*
From
> It doesn't make sense to do this.  KERN_ERR puts a "<3>" in front of
> the line so we know how important it is, but it's a blank line
> because of the "\n" at the start.
>
> Also the should probably be using pr_err() or dev_err().
>
> ...
>
> These put a "<3>" in the middle of the line which doesn't help
> anyone.  Rewrite it so it's on one line.  Get rid of the OK line.

Ah yes. I will fold things up so that printk isn't adding level
messages in the middle of the line. In the case where the dmesg line
is incrementally being built up, I may patch the generating logic so
everything is made from a single call to printk.

Thanks for the feedback. I am just picking this up and this is my 2nd
patch (set?) ever :)

~s
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-01-21 18:17    [W:0.107 / U:1.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site