[lkml]   [2012]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN_*
    On Sat, 2012-01-21 at 11:22 -0800, sam hansen wrote:
    > > One other thing. It would be better to add
    > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
    > > before any #include and convert all the
    > > printks(KERN_<LEVEL> to pr_<level>(
    > > stripping all the leading XGIfb: too.
    > So, an administrative question. Sorry for my noob-ishness but... I
    > will be 1) modifying the patch regarding prink to use pr_LVL (and a
    > few logic tweaks), and will also be introducing a new patch to set up
    > the pr_fmt macro for kbuild. I can find lots of information regarding
    > how to create/submit a patch, but not a lot of information about how
    > to modify/resubmit a patch you've already submitted and received
    > feedback for.

    Rework the commented things in a new branch.

    Apply the patches to the new branch one at
    a time, modify as necessary then
    git commit --amend
    the appropriately changed files while modifying
    change logs.

    Then resubmit with
    git format-patch --subject-prefix="PATCH V2"
    You could also add --in-reply-to=originalemailid

    > The pr_fmt patch will likely just be a new patch outside of this patch
    > set?

    A new patch would be fine.
    Here's a little regex based tool for part of that conversion

    An example would be:
    $ ./scripts/ \
    --convert=convert_printk_to_pr_level \
    -o drivers/staging/xgifb/XGI_main_26.c

     \ /
      Last update: 2012-01-21 20:49    [W:0.020 / U:44.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site