lkml.org 
[lkml]   [2012]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN_*
    From
    Date
    On Sat, 2012-01-21 at 02:10 -0800, Sam Hansen wrote:
    > Added KERN_ facility levels in XGI_main_26.c and vb_init.c in a few different
    > printk() statements.
    []
    > @@ -2018,12 +2018,12 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
    > printk(KERN_INFO "XGIfb: MMIO at 0x%lx, mapped to 0x%p, size %ldk\n",
    > xgifb_info->mmio_base, xgifb_info->mmio_vbase,
    > xgifb_info->mmio_size / 1024);
    > - printk("XGIfb: XGIInitNew() ...");
    > + printk(KERN_INFO "XGIfb: XGIInitNew() ...");
    > pci_set_drvdata(pdev, xgifb_info);
    > if (XGIInitNew(pdev))
    > - printk("OK\n");
    > + printk(KERN_INFO "OK\n");
    > else
    > - printk("Fail\n");
    > + printk(KERN_ERR "Fail\n");

    These last two should be KERN_CONT
    though the block could be rewritten as

    if (XGIInitNew(pdev))
    printk(KERN_INFO "XGIfb: XGIInitNew() ... OK\n");
    else
    printk(KERN_ERR "XGIfb: XGIInitNew() ... Fail\n");

    Emitting any dmesg output like "XGIInitNew() ... OK\n"
    is almost always low value.

    Perhaps just emitting on the error case is better:
    if (!XGIInitNew(pdev))
    printk(KERN_ERR "XGIfb: XBIInitNew() failed\n");

    One other thing. It would be better to add
    #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
    before any #include and convert all the
    printks(KERN_<LEVEL> to pr_<level>(
    stripping all the leading XGIfb: too.




    \
     
     \ /
      Last update: 2012-01-21 17:45    [W:0.019 / U:31.652 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site