lkml.org 
[lkml]   [2011]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[51/55] ALSA: sound/core/pcm_compat.c: adjust array index
    2.6.32-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Julia Lawall <julia@diku.dk>

    commit ca9380fd68514c7bc952282c1b4fc70607e9fe43 upstream.

    Convert array index from the loop bound to the loop index.

    A simplified version of the semantic patch that fixes this problem is as
    follows: (http://coccinelle.lip6.fr/)

    // <smpl>
    @@
    expression e1,e2,ar;
    @@

    for(e1 = 0; e1 < e2; e1++) { <...
    ar[
    - e2
    + e1
    ]
    ...> }
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    sound/core/pcm_compat.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/core/pcm_compat.c
    +++ b/sound/core/pcm_compat.c
    @@ -341,7 +341,7 @@ static int snd_pcm_ioctl_xfern_compat(st
    kfree(bufs);
    return -EFAULT;
    }
    - bufs[ch] = compat_ptr(ptr);
    + bufs[i] = compat_ptr(ptr);
    bufptr++;
    }
    if (dir == SNDRV_PCM_STREAM_PLAYBACK)



    \
     
     \ /
      Last update: 2011-08-06 02:13    [W:0.020 / U:88.524 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site