Messages in this thread |  | | | Subject | Re: [Stable-review] [07/55] SUNRPC: Fix a race between work-queue and rpc_killall_tasks | | From | Ben Hutchings <> | | Date | Sun, 07 Aug 2011 18:38:01 +0100 |
| |
On Fri, 2011-08-05 at 17:01 -0700, Greg KH wrote: > 2.6.32-longterm review patch. If anyone has any objections, please let us know. > > ------------------ > > From: Trond Myklebust <Trond.Myklebust@netapp.com> > > commit b55c59892e1f3b6c7d4b9ccffb4263e1486fb990 upstream. > > Since rpc_killall_tasks may modify the rpc_task's tk_action field > without any locking, we need to be careful when dereferencing it. [...]
This isn't nearly careful enough to avoid races. You must at least use the ACCESS_ONCE macro, otherwise the compiler can just optimise away the local variable this introduces.
Ben.
[unhandled content-type:application/pgp-signature] |  |