lkml.org 
[lkml]   [2011]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[24/55] [SCSI] libsas: remove expander from dev list on error
    2.6.32-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Luben Tuikov <ltuikov@yahoo.com>

    commit 5911e963d3718e306bcac387b83e259aa4228896 upstream.

    If expander discovery fails (sas_discover_expander()), remove the
    expander from the port device list (sas_ex_discover_expander()),
    before freeing it. Else the list is corrupted and, e.g., when we
    attempt to send SMP commands to other devices, the kernel oopses.

    Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
    Reviewed-by: Jack Wang <jack_wang@usish.com>
    Signed-off-by: James Bottomley <JBottomley@Parallels.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/scsi/libsas/sas_expander.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/scsi/libsas/sas_expander.c
    +++ b/drivers/scsi/libsas/sas_expander.c
    @@ -840,6 +840,9 @@ static struct domain_device *sas_ex_disc

    res = sas_discover_expander(child);
    if (res) {
    + spin_lock_irq(&parent->port->dev_list_lock);
    + list_del(&child->dev_list_node);
    + spin_unlock_irq(&parent->port->dev_list_lock);
    kfree(child);
    return NULL;
    }



    \
     
     \ /
      Last update: 2011-08-06 02:11    [W:0.036 / U:61.552 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site