Messages in this thread | | | Date | Mon, 18 Jul 2011 22:28:25 +0200 (CEST) | From | Jan Engelhardt <> | Subject | Re: [PATCH] netfilter: add per-namespace logging to nfnetlink_log.c |
| |
On Monday 2011-07-18 22:17, Rainer Weikusat wrote: >David Miller <davem@davemloft.net> writes: >> >>> [rw@sapphire]~/work/linux-2-6/net/netfilter $find -name '*.c' | xargs grep '^#ifdef' | wc -l >>> 239 >> >> You've shown nothing. Showing exceptions does not prove that the >> general effort has been to keep ifdef crap out of *.c files. > >I've 'shown' that the networking code contains a fair amount of >#ifdefs in .c files. Consequently, 'we did it without' is wrong. At >best, 'we would like to do without in future' seems justified.
Your count of ifdefs is just telling that we use ifdef, not how we use it.
There is a difference between #ifdefs sprinkled inside a function, and #ifdefs around functions or larger groups where possible, feasible and optically preferable (cf. security.h, xt_TEE.c).
| |