Messages in this thread |  | | | Date | Tue, 19 Jul 2011 11:42:26 +0200 | | From | Patrick McHardy <> | | Subject | Re: [PATCH] netfilter: add per-namespace logging to nfnetlink_log.c |
| |
On 18.07.2011 22:32, Alexey Dobriyan wrote: > On Mon, Jul 18, 2011 at 01:19:43PM -0700, David Miller wrote: >> From: Rainer Weikusat <rweikusat@mobileactivedefense.com> >> Date: Mon, 18 Jul 2011 21:17:00 +0100 >> >>> David Miller <davem@davemloft.net> writes: >>>> We're also specifically talking about namespace stuff, so you should have >>>> at least refined your match criteria just a little bit. >>> >>> The person I was replying to wrote 'We did whole networking without >>> sprinkling ifdefs'. >> >> He was talking specifically about namespace stuff. > > Indeed. > > Rainer, while your desire to keep CONFIG_NET_NS=n case equivalent > to current code is understandable and kernel people share it at large, > what you're fighting for is maybe one dereference on speed-uncritical > code paths and one pointer in small amount of data structures. > As such having common executable code matters more. > > netns will be stubbed to &init_net at several places. > See how e. g. xt_hashlimit is done.
Indeed, that's the alternative to putting it directly into struct netns, not using tons of ifdefs.
|  |