Messages in this thread | | | Date | Mon, 18 Jul 2011 12:46:38 -0700 (PDT) | Subject | Re: [PATCH] netfilter: add per-namespace logging to nfnetlink_log.c | From | David Miller <> |
| |
From: Rainer Weikusat <rweikusat@mobileactivedefense.com> Date: Mon, 18 Jul 2011 20:43:30 +0100
> [rw@sapphire]~/work/linux-2-6/net/netfilter $find -name '*.c' | xargs grep '^#ifdef' | wc -l > 239 > [rw@sapphire]~/work/linux-2-6/net/netfilter $.. > [rw@sapphire]~/work/linux-2-6/net $find -name '*.c' | xargs grep '^#ifdef' | wc -l > 1672
You've shown nothing. Showing exceptions does not prove that the general effort has been to keep ifdef crap out of *.c files.
And every developer or maintainer who says no to ifdefs in *.c files for new changes is %100 right.
We're also specifically talking about namespace stuff, so you should have at least refined your match criteria just a little bit.
| |