lkml.org 
[lkml]   [2011]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] netfilter: add per-namespace logging to nfnetlink_log.c
From
From: Rainer Weikusat <rweikusat@mobileactivedefense.com>
Date: Mon, 18 Jul 2011 20:43:30 +0100

> [rw@sapphire]~/work/linux-2-6/net/netfilter $find -name '*.c' | xargs grep '^#ifdef' | wc -l
> 239
> [rw@sapphire]~/work/linux-2-6/net/netfilter $..
> [rw@sapphire]~/work/linux-2-6/net $find -name '*.c' | xargs grep '^#ifdef' | wc -l
> 1672

You've shown nothing. Showing exceptions does not prove that the
general effort has been to keep ifdef crap out of *.c files.

And every developer or maintainer who says no to ifdefs in *.c files
for new changes is %100 right.

We're also specifically talking about namespace stuff, so you should have
at least refined your match criteria just a little bit.


\
 
 \ /
  Last update: 2011-07-18 21:49    [W:3.184 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site