lkml.org 
[lkml]   [2011]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectreorganized struct inode results in unaligned accesses
A week ago I noticed that in 3.0.0-rc3, sparc64 machines log a lot of 
unaligned accesses in different vfs functions in dmesg. I reported but
obviously not well enough. Today I had a look at it and found the
reason.

Commit 13e12d14e2dccc7995b8f15a5678a338ab4e6a8c (vfs: reorganize 'struct
inode' layout a bit) changes i_state to be unsigned int instead of
unsigned long. This is the cause of unaligned accesses on sparc64 and
maybe others. Changing it back to unsigned long fixes the warnings but I
did not look at the layout of the resulting struct - might leave a hole
there.

--
Meelis Roos (mroos@linux.ee)


\
 
 \ /
  Last update: 2011-06-19 18:35    [W:0.062 / U:1.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site