lkml.org 
[lkml]   [2011]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateSun, 19 Jun 2011 16:01:50 -0700 (PDT)
SubjectRe: reorganized struct inode results in unaligned accesses
FromDavid Miller <>
From: Andi Kleen <andi@firstfloor.org>
Date: Sun, 19 Jun 2011 15:35:30 -0700

> Linus Torvalds <torvalds@linux-foundation.org> writes:
>>
>> Dang. I guess it needs to be made "unsigned long" again. Which is a
>> shame, because we only use a couple of bits from there, and "struct
>> inode" really is much too big already.
>
> In the past it was usually enough to just align it to alignof(unsigned
> long), not actually make it long. struct page went through this
> a long time ago.

Hmmm, can this scheme actually work out properly on both big and
little endian? Because endianness determines whether the bits start
in the "lower addressed" 32-bit word or the "higher addressed" 32-bit
word.

If this trick is being attempted elsewhere, I think it could perhaps
account for some strange bugs :-)


\
 
 \ /
  Last update: 2011-06-20 01:05    [from the cache]
©2003-2010