lkml.org 
[lkml]   [2011]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] mm/page_alloc: use appropriate printk priority level
On 01/27/2011 12:29 PM, Mandeep Singh Baines wrote:
> printk()s without a priority level default to KERN_WARNING. To reduce
> noise at KERN_WARNING, this patch set the priority level appriopriately
> for unleveled printks()s. This should be useful to folks that look at
> dmesg warnings closely.
>
> Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
> ---

> @@ -4700,33 +4700,36 @@ void __init free_area_init_nodes(unsigned long *max_zone_pfn)
> find_zone_movable_pfns_for_nodes(zone_movable_pfn);
>
> /* Print out the zone ranges */
> - printk("Zone PFN ranges:\n");
> + printk(KERN_INFO "Zone PFN ranges:\n");
> for (i = 0; i < MAX_NR_ZONES; i++) {
> if (i == ZONE_MOVABLE)
> continue;
> - printk(" %-8s ", zone_names[i]);
> + printk(KERN_INFO " %-8s ", zone_names[i]);
> if (arch_zone_lowest_possible_pfn[i] ==
> arch_zone_highest_possible_pfn[i])
> printk("empty\n");

Should be printk(KERN_CONT ... (or pr_cont).

> else
> - printk("%0#10lx -> %0#10lx\n",
> + printk(KERN_INFO "%0#10lx -> %0#10lx\n",
> arch_zone_lowest_possible_pfn[i],
> arch_zone_highest_possible_pfn[i]);

The printk above doesn't have a trailing newline so this should be
printk(KERN_CONT ...

There are a couple of other places in this patch series that also need
to be fixed in a similar manner.

~Ryan

--
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan@bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934


\
 
 \ /
  Last update: 2011-01-27 01:35    [W:0.307 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site