lkml.org 
[lkml]   [2011]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig
Joe Perches (joe@perches.com) wrote:
> On Tue, 2011-01-25 at 15:57 -0800, Mandeep Singh Baines wrote:
> > To make it easier to audit dmesg, we'd like to make
> > DEFAULT_MESSAGE_LEVEL Kconfig-settable. That way we can set it to
> > KERN_NOTICE and audit any messages <= KERN_WARNING.
>
> Seems sensible, but mightn't it be better to make sure
> that all printks use a specific KERN_<level> rather
> than check that printks without a KERN_<level> are
> emitted at a selectable level?
>

Can we do both? I was planning sending cleanup patches as well but expected
that process to take a while. The simplest thing would to set all these
to KERN_WARNING but that's not correct and leaves me back where I started.
The correct thing would be to set each printk to an appropriate level.
Determining appropriate level will take some discussion (so a long term
project).

>


\
 
 \ /
  Last update: 2011-01-26 02:05    [W:0.160 / U:1.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site