Messages in this thread | | | From | WANG Cong <> | Subject | Re: [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig | Date | Thu, 27 Jan 2011 05:49:04 +0000 (UTC) |
| |
On Wed, 26 Jan 2011 15:05:48 -0800, Mandeep Baines wrote:
> On Tue, Jan 25, 2011 at 8:18 PM, WANG Cong <xiyou.wangcong@gmail.com> > wrote: >> >> On Tue, 25 Jan 2011 15:57:00 -0800, Mandeep Singh Baines wrote: >> >> > We've been burned by regressions/bugs which we later realized could >> > have been triaged quicker if only we'd paid closer attention to >> > dmesg. To make it easier to audit dmesg, we'd like to make >> > DEFAULT_MESSAGE_LEVEL Kconfig-settable. That way we can set it to >> > KERN_NOTICE and audit any messages <= KERN_WARNING. >> > >> > >> Why? We already have "loglevel=" kernel parameter. >> >> > loglevel allows you to control which messages go to the console. > > DEFAULT_MESSAGE_LEVEL selects the default message levels for printk()s > which don't specify a message level.
I think you should fix them instead.
> > Most printks()s without a message level aren't really warnings and just > create noise > if you're trying to look closely at all warnings. Some of this is just > old code but new > printk()s without a message level do get committed from time to time. >
IIRC, checkpatch.pl will complain about this.
| |