Messages in this thread | | | Date | Wed, 07 Jul 2010 16:21:00 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH] x86: KVM, fix lock imbalance |
| |
On 07/07/2010 04:07 PM, Jiri Slaby wrote: > >> A cleanliness comment: why is that tear-down/dealloc sequence open-coded? It >> should be at the end of the function, with goto labels, like we do it in >> similar cases. >> > Because the lock is around a block only. I usually don't create a goto > fail-paths in these cases. Do you want one? >
In any case, the patch is a minimal fix, so I'll apply it. Any clean ups can go on top.
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
| |