[lkml]   [2010]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] x86: KVM, fix lock imbalance
On 07/07/2010 04:07 PM, Jiri Slaby wrote:
>> A cleanliness comment: why is that tear-down/dealloc sequence open-coded? It
>> should be at the end of the function, with goto labels, like we do it in
>> similar cases.
> Because the lock is around a block only. I usually don't create a goto
> fail-paths in these cases. Do you want one?

In any case, the patch is a minimal fix, so I'll apply it. Any clean
ups can go on top.

I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

 \ /
  Last update: 2010-07-07 15:23    [W:0.064 / U:11.924 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site