lkml.org 
[lkml]   [2010]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: KVM, fix lock imbalance
On 07/07/2010 03:07 PM, Jiri Slaby wrote:
>>> --- a/arch/x86/kvm/i8254.c
>>> +++ b/arch/x86/kvm/i8254.c
>>> @@ -696,6 +696,7 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags)
>>>
>>> pit->wq = create_singlethread_workqueue("kvm-pit-wq");
>>> if (!pit->wq) {
>>> + mutex_unlock(&pit->pit_state.lock);
>>> kfree(pit);
>>> return NULL;
>>> }
>>
>> A cleanliness comment: why is that tear-down/dealloc sequence open-coded? It
>> should be at the end of the function, with goto labels, like we do it in
>> similar cases.
>
> Because the lock is around a block only. I usually don't create a goto
> fail-paths in these cases.

To be more precise what I mean by that:
if ()
return;

lock();
...
if () { [single if inside the crit section]
unlock();
return;
}
...
unlock()

...
if ()
return;
...
if ()
return;

--
js


\
 
 \ /
  Last update: 2010-07-07 15:15    [W:0.045 / U:2.092 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site