lkml.org 
[lkml]   [2010]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: KVM, fix lock imbalance

    * Jiri Slaby <jirislaby@gmail.com> wrote:

    > Stanse found that there is an omitted unlock in kvm_create_pit in one fail
    > path. Add proper unlock there.
    >
    > Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    > Cc: Avi Kivity <avi@redhat.com>
    > Cc: Marcelo Tosatti <mtosatti@redhat.com>
    > Cc: Thomas Gleixner <tglx@linutronix.de>
    > Cc: Ingo Molnar <mingo@redhat.com>
    > Cc: "H. Peter Anvin" <hpa@zytor.com>
    > Cc: x86@kernel.org
    > Cc: Gleb Natapov <gleb@redhat.com>
    > Cc: "Michael S. Tsirkin" <mst@redhat.com>
    > Cc: Gregory Haskins <ghaskins@novell.com>
    > Cc: kvm@vger.kernel.org
    > ---
    > arch/x86/kvm/i8254.c | 1 +
    > 1 files changed, 1 insertions(+), 0 deletions(-)
    >
    > diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
    > index 467cc47..70db4d4 100644
    > --- a/arch/x86/kvm/i8254.c
    > +++ b/arch/x86/kvm/i8254.c
    > @@ -696,6 +696,7 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags)
    >
    > pit->wq = create_singlethread_workqueue("kvm-pit-wq");
    > if (!pit->wq) {
    > + mutex_unlock(&pit->pit_state.lock);
    > kfree(pit);
    > return NULL;
    > }

    A cleanliness comment: why is that tear-down/dealloc sequence open-coded? It
    should be at the end of the function, with goto labels, like we do it in
    similar cases.

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2010-07-07 15:09    [W:0.023 / U:118.372 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site