lkml.org 
[lkml]   [2010]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH 11/12] wm8978: fix a memory leak if another WM8978 is registered
From
Date
wm8978 is allocated in wm8978_i2c_probe() but is not freed if wm8978_register()
return -EINVAL (if another WM8978 is registered).

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/wm8978.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8978.c b/sound/soc/codecs/wm8978.c
index 51d5f43..4e80323 100644
--- a/sound/soc/codecs/wm8978.c
+++ b/sound/soc/codecs/wm8978.c
@@ -1007,7 +1007,8 @@ static __devinit int wm8978_register(struct wm8978_priv *wm8978)

if (wm8978_codec) {
dev_err(codec->dev, "Another WM8978 is registered\n");
- return -EINVAL;
+ ret = -EINVAL;
+ goto err;
}

/*
--
1.5.4.3




\
 
 \ /
  Last update: 2010-07-15 05:11    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site