lkml.org 
[lkml]   [2010]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2/12] ak4642: fix a memory leak if failed to initialise AK4642
    From
    Date
    ak4642 should be kfreed if ak4642_init() return error.

    Signed-off-by: Axel Lin <axel.lin@gmail.com>
    ---
    sound/soc/codecs/ak4642.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)

    diff --git a/sound/soc/codecs/ak4642.c b/sound/soc/codecs/ak4642.c
    index 7528a54..4feefa8 100644
    --- a/sound/soc/codecs/ak4642.c
    +++ b/sound/soc/codecs/ak4642.c
    @@ -491,8 +491,10 @@ static int ak4642_i2c_probe(struct i2c_client *i2c,
    codec->control_data = i2c;

    ret = ak4642_init(ak4642);
    - if (ret < 0)
    + if (ret < 0) {
    printk(KERN_ERR "failed to initialise AK4642\n");
    + kfree(ak4642);
    + }

    return ret;
    }
    --
    1.5.4.3




    \
     
     \ /
      Last update: 2010-07-15 04:53    [W:0.020 / U:60.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site