lkml.org 
[lkml]   [2010]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/12] ad1836: fix a memory leak if another ad1836 is registered
    On Thu, Jul 15, 2010 at 10:50 AM, Axel Lin <axel.lin@gmail.com> wrote:
    > ad1836 is allocated in ad1836_spi_probe() but is not freed if ad1836_register()
    > return -EINVAL (if another ad1836 is registered).
    >
    > Signed-off-by: Axel Lin <axel.lin@gmail.com>

    Acked-by: Barry Song <21cnbao@gmail.com>

    > ---
    >  sound/soc/codecs/ad1836.c |    1 +
    >  1 files changed, 1 insertions(+), 0 deletions(-)
    >
    > diff --git a/sound/soc/codecs/ad1836.c b/sound/soc/codecs/ad1836.c
    > index 2175384..a01006c 100644
    > --- a/sound/soc/codecs/ad1836.c
    > +++ b/sound/soc/codecs/ad1836.c
    > @@ -272,6 +272,7 @@ static int ad1836_register(struct ad1836_priv *ad1836)
    >
    >        if (ad1836_codec) {
    >                dev_err(codec->dev, "Another ad1836 is registered\n");
    > +               kfree(ad1836);
    >                return -EINVAL;
    >        }
    >
    > --
    > 1.5.4.3
    >
    >
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at  http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at  http://www.tux.org/lkml/
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-07-20 12:35    [W:0.021 / U:30.792 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site