[lkml]   [2009]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC] Freescale MC13783 PMIC support
    On Tue, 11 Aug 2009 11:07:42 +0200
    Sascha Hauer <> wrote:

    > Hi all,
    > This series adds support for the Freescale MC13783 PMIC. The MC13783
    > is connected via SPI, the first patch adds basic support for it in
    > drivers/mfd. The rest of the patches can be applied independently.
    > Individual Maintainers are on Cc, the whole series can be found on
    > lkml and the Arm Linux Kernel mailing list.
    > Please ignore the previous mail which lacked the intrductory mail.
    > Sascha

    Hi Sascha,

    the MC13783 is also named Atlas, isn't it?
    Maybe you can add this name somewhere in comments or in Kconfig entry
    to help greppers and web crawlers.

    BTW, I only took a very brief look to some of your patches, and here's
    some humble thoughts, sorry if I don't comment patch by patch.

    There is a driver queued for inclusion in 2.6.31 for the PCAP2
    PMIC, which is quite similar to MC13783. This driver uses the irq_chip
    mechanism to expose the PMIC IRQs to be used as general IRQs in
    sub-devices drivers (which you call client-devices AFAICS). Also, it
    passed all the reviews so maybe you can give it a look to take some
    other solution already accepted by reviewers, like passing sub-devices
    via platform data (some of the phones which use PCAP2 don't have
    touchscreen, for instance), generalize the driver so to handle multiple
    PMICs in one system (quite unlikely scenario?), read actual pressure
    in TS driver.

    The latest (fixed) version of the core and ADC driver is in [1], but you
    can find also the regulator and input drivers in [2] which are queued
    for 2.6.32, the rtc driver can be found in [3]





    Antonio Ospite

    PGP public key ID: 0x4553B001

    A: Because it messes up the order in which people normally read text.
    Q: Why is top-posting such a bad thing?
    A: Top-posting.
    Q: What is the most annoying thing in e-mail?
    [unhandled content-type:application/pgp-signature]
     \ /
      Last update: 2009-08-11 14:27    [W:0.026 / U:3.236 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site