Messages in this thread | | | Date | Wed, 12 Aug 2009 09:01:28 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 2/5] [input] add mc13783 touchscreen driver |
| |
On Wed, Aug 12, 2009 at 01:10:18PM +0200, Sascha Hauer wrote: > Hi Dmitry > > On Tue, Aug 11, 2009 at 07:15:33PM -0700, Dmitry Torokhov wrote: > > Hi Sascha, > > > > On Tue, Aug 11, 2009 at 11:07:44AM +0200, Sascha Hauer wrote: > > > + > > > + INIT_DELAYED_WORK(&priv->work, mc13783_ts_work); > > > + > > > + priv->workq = create_singlethread_workqueue("mc13783_ts"); > > > > Do you really need a separate workqueue? Would not keventd suffice? > > Yes, I do. mc13783_adc_do_conversion() runs in a workqueue aswell. With > keventd I would deadlock. >
I see. Then please add a comment why it is needed so nobody is tempted to doa "cleanup" ;)
-- Dmitry
| |