Messages in this thread | | | Date | Tue, 11 Aug 2009 11:19:40 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 5/5] [regulator] Add a Freescale MC13783 regulator driver |
| |
On Tue, Aug 11, 2009 at 11:07:47AM +0200, Sascha Hauer wrote:
This looks basically OK - a few small nitpicks below.
> +static int mc13783_enable(struct regulator_dev *rdev) > +{ > + struct mc13783_priv *priv = rdev_get_drvdata(rdev); > + int id = rdev_get_id(rdev); > + > + dev_info(rdev_get_dev(rdev), "%s id: %d\n", __func__, id);
This is too verbose - it should be dev_dbg() if anything.
> +static int __devinit mc13783_regulator_probe(struct platform_device *pdev) > +{ > + struct mc13783_priv *priv; > + struct mc13783 *mc13783 = pdev->dev.platform_data; > + struct mc13783_regulator_init_data *init_data; > + int i, ret; > + > + dev_info(&pdev->dev, "mc13783_regulator_probe id %d\n", pdev->id);
dev_dbg() please.
> +static int __init mc13783_regulator_init(void) > +{ > + return platform_driver_register(&mc13783_regulator_driver); > +} > +module_init(mc13783_regulator_init);
This should be subsys_initcall().
| |