Messages in this thread | | | Date | Tue, 21 Jul 2009 11:40:44 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 01/14] amd64_edac: simplify error type bits extractors |
| |
On Mon, Jul 20, 2009 at 01:56:44PM -0400, Aristeu Rozanski wrote: > Hi Borislav, > > - /* If this was an 'observed' error, early out */ > > - if (ec_pp == K8_NBSL_PP_OBS) > > - return; /* We aren't the node involved */ > > + > > + /* Bail early out if this was an 'observed' error */ > > + if (((ec >> 9) & 0x3) == K8_NBSL_PP_OBS) > > + return; > minor thing: > this patch and others makes me think if it wouldn't be better to have: > #define PP(x) (((x) >> 9) & 0x3) > #define PP_MSG(x) pp_msgs[PP(x)] > and the same for LL, TT, RRRR.
Yep, it seems that way, will fix :).
Thanks.
-- Regards/Gruss, Boris.
Operating | Advanced Micro Devices GmbH System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany Research | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München (OSRC) | Registergericht München, HRB Nr. 43632
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |