lkml.org 
[lkml]   [2009]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/14] mce3: pass mce info to EDAC for decoding
On Mon, Jul 20, 2009 at 06:12:58PM +0200, Borislav Petkov wrote:
> Use a weakly defined symbol instead of ugly ifdefs.

I'm not sure what you're trying to archive, but if you're
trying to catch corrected MCs you're hooking into the
wrong function. print_mce is only called for PCC=1.

Also if you're checking for specific banks you
need to check for vendor/cpu model first of course.
In your current implementation e.g. a Intel CPU
would pass some random event into your AMD specific code,
which is probably not intended and might even crash.

It would be probably cleaner if you defined a standard
notifier chain interface.

-Andi


\
 
 \ /
  Last update: 2009-07-20 20:07    [W:0.154 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site