lkml.org 
[lkml]   [2009]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/7] [AVR32] don't check platform_get_irq's return value against zero
    Date
    platform_get_irq returns -ENXIO on failure, so !int_irq was probably
    always true. Better use (int)int_irq <= 0. Note that a return value of
    zero is still handled as error even though this could mean irq0.

    This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
    changed the return value of platform_get_irq from 0 to -ENXIO on error.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: David Vrabel <dvrabel@arcom.com>
    Cc: Greg Kroah-Hartman <gregkh@suse.de>
    Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>
    ---
    arch/avr32/mach-at32ap/extint.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/avr32/mach-at32ap/extint.c b/arch/avr32/mach-at32ap/extint.c
    index 310477b..033f693 100644
    --- a/arch/avr32/mach-at32ap/extint.c
    +++ b/arch/avr32/mach-at32ap/extint.c
    @@ -198,7 +198,7 @@ static int __init eic_probe(struct platform_device *pdev)

    regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    int_irq = platform_get_irq(pdev, 0);
    - if (!regs || !int_irq) {
    + if (!regs || (int)int_irq <= 0) {
    dev_dbg(&pdev->dev, "missing regs and/or irq resource\n");
    return -ENXIO;
    }
    --
    1.6.5.2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-12-16 17:13    [W:0.034 / U:1.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site