lkml.org 
[lkml]   [2010]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RESEND PATCH 3/5] V4L/DVB sh_mobile_ceu: don't check platform_get_irq's return value against zero
    Date
    platform_get_irq returns -ENXIO on failure, so !irq was probably
    always true. Better use (int)irq <= 0. Note that a return value of
    zero is still handled as error even though this could mean irq0.

    This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
    changed the return value of platform_get_irq from 0 to -ENXIO on error.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: David Vrabel <dvrabel@arcom.com>
    Cc: Greg Kroah-Hartman <gregkh@suse.de>
    Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
    Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
    Cc: Magnus Damm <damm@igel.co.jp>
    Cc: Kuninori Morimoto <morimoto.kuninori@renesas.com>
    Cc: Paul Mundt <lethal@linux-sh.org>
    Cc: linux-media@vger.kernel.org
    ---
    drivers/media/video/sh_mobile_ceu_camera.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/media/video/sh_mobile_ceu_camera.c b/drivers/media/video/sh_mobile_ceu_camera.c
    index d69363f..f09c714 100644
    --- a/drivers/media/video/sh_mobile_ceu_camera.c
    +++ b/drivers/media/video/sh_mobile_ceu_camera.c
    @@ -1827,7 +1827,7 @@ static int __devinit sh_mobile_ceu_probe(struct platform_device *pdev)

    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    irq = platform_get_irq(pdev, 0);
    - if (!res || !irq) {
    + if (!res || (int)irq <= 0) {
    dev_err(&pdev->dev, "Not enough CEU platform resources.\n");
    err = -ENODEV;
    goto exit;
    --
    1.6.6
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-01-13 12:09    [W:0.021 / U:1.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site