Messages in this thread | | | Subject | Re: [PATCH] ftrace: return error instead of 12 bytes read | From | Steven Rostedt <> | Date | Wed, 11 Nov 2009 16:57:41 -0500 |
| |
On Wed, 2009-11-11 at 22:26 +0100, Roel Kluin wrote: > A negative error value is required: now we cannot > distinguish ENOMEM from a valid read of 12 bytes. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Thanks! I'll pull this in right away and get it out to Ingo.
-- Steve
> --- > kernel/trace/trace.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index b20d3ec..03c7fd5 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -3730,7 +3730,7 @@ tracing_stats_read(struct file *filp, char __user *ubuf, > > s = kmalloc(sizeof(*s), GFP_KERNEL); > if (!s) > - return ENOMEM; > + return -ENOMEM; > > trace_seq_init(s); >
| |