Messages in this thread | | | Date | Wed, 11 Nov 2009 13:47:30 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] ftrace: return error instead of 12 bytes read |
| |
On Wed, 11 Nov 2009 22:26:35 +0100 Roel Kluin <roel.kluin@gmail.com> wrote:
> A negative error value is required: now we cannot > distinguish ENOMEM from a valid read of 12 bytes. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > kernel/trace/trace.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index b20d3ec..03c7fd5 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -3730,7 +3730,7 @@ tracing_stats_read(struct file *filp, char __user *ubuf, > > s = kmalloc(sizeof(*s), GFP_KERNEL); > if (!s) > - return ENOMEM; > + return -ENOMEM; > > trace_seq_init(s); >
lol, there we go again.
Andy, can we have a checkpatch rule please?
| |