Messages in this thread |  | | | Date | Thu, 12 Nov 2009 13:31:34 +0000 | | Subject | Re: [PATCH] ftrace: return error instead of 12 bytes read | | From | Andy Whitcroft <> |
| |
>> s = kmalloc(sizeof(*s), GFP_KERNEL); >> if (!s) >> - return ENOMEM; >> + return -ENOMEM; >> >> trace_seq_init(s); >> > > lol, there we go again. > > Andy, can we have a checkpatch rule please?
Thats a tricky one. Not only do we not really have a sensible way to know if ENOMEM is an errno, we also find a bunch of places that we appear to use positive errno's as return values where we would falsly complain about. Its particularly common in scsi and filesystems. Admittedly the vast majority are return -EXXX form, so we could add this as a non-default check perhaps.
Thoughts?
-apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |