lkml.org 
[lkml]   [2008]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/30] W1: w1 core fixes, ds2490 updates, strong pullup
On Mon, 28 Jul 2008 21:04:33 -0500
David Fries <david@fries.net> wrote:

> What follows is a long list of fixes and enhancements to the one wire
> system, and even some documentation.
>
> I no longer have any deadlocks, a thread was eliminated (along with
> its one second wakeup interval), the cpu and time overhead are much
> reduced for one wire accesses. The time for the ds2490 to read a
> temperature sensor went from 3.91 seconds (.002s user, 3.001s system)
> to 0.860 seconds (0.004s user, 0.004s system). I also added support
> for the strong pullup to provide more current when requested.

This is all dreadfully late for 2.6.27, but it does seem to be rather
important, so let's aim for 2.6.27.


The w1 code seems to have rather a lot of comments which start with /**
but which aren't kerneldoc comments. But /** is exclusively used to
signify the start of a kerneldoc comment. Please let's not invent new
commenting styles like this. Documentation/CodingStyle is there to
help.

Please be aware that this:

Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="OgqxwSJOaUobr8KG"

is rather receiver-hostile. My MUA (at least) (sylpheed) manages to
make a complete mess when saving-to-file, so I needed to go through all
the patches and do various manual steps to fix this up. I may still have
some "=066"s in the changelogs.

Also, some MUAs (but not sylpheed) may be unable to quote the patch
text when someone does a reply to your email, which is also a bit of a
hassle.

Nothing beats plain old ascii text. Preferably non-wordwrapped,
non-tab-replaced, non-spacestuffed ascii text (which is becoming
increasingly rare).




\
 
 \ /
  Last update: 2008-07-30 01:17    [from the cache]
©2003-2011 Jasper Spaans