lkml.org 
[lkml]   [2008]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 13/30] W1: w1_family, remove unused variable need_exit
    Removed the w1_family structure member variable need_exit.  It was
    only being set and never used. Even if it were to be used it is a
    polling type operation.

    Signed-off-by: David Fries <david@fries.net>
    Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
    ---
    drivers/w1/w1_family.c | 7 +------
    drivers/w1/w1_family.h | 1 -
    2 files changed, 1 insertions(+), 7 deletions(-)

    diff --git a/drivers/w1/w1_family.c b/drivers/w1/w1_family.c
    index 8c35f9c..4a09904 100644
    --- a/drivers/w1/w1_family.c
    +++ b/drivers/w1/w1_family.c
    @@ -48,7 +48,6 @@ int w1_register_family(struct w1_family *newf)

    if (!ret) {
    atomic_set(&newf->refcnt, 0);
    - newf->need_exit = 0;
    list_add_tail(&newf->family_entry, &w1_families);
    }
    spin_unlock(&w1_flock);
    @@ -73,9 +72,6 @@ void w1_unregister_family(struct w1_family *fent)
    break;
    }
    }
    -
    - fent->need_exit = 1;
    -
    spin_unlock(&w1_flock);

    /* deatch devices using this family code */
    @@ -113,8 +109,7 @@ struct w1_family * w1_family_registered(u8 fid)

    static void __w1_family_put(struct w1_family *f)
    {
    - if (atomic_dec_and_test(&f->refcnt))
    - f->need_exit = 1;
    + atomic_dec(&f->refcnt);
    }

    void w1_family_put(struct w1_family *f)
    diff --git a/drivers/w1/w1_family.h b/drivers/w1/w1_family.h
    index 296a87e..3053133 100644
    --- a/drivers/w1/w1_family.h
    +++ b/drivers/w1/w1_family.h
    @@ -53,7 +53,6 @@ struct w1_family
    struct w1_family_ops *fops;

    atomic_t refcnt;
    - u8 need_exit;
    };

    extern spinlock_t w1_flock;
    --
    1.4.4.4[unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2008-07-29 04:25    [W:0.040 / U:32.604 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site