lkml.org 
[lkml]   [2008]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [Bugme-new] [Bug 10326] New: inconsistent lock state in net_rx_action
From
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date: Thu, 27 Mar 2008 11:56:19 +0100

> How about this:
>
> <irqs disabled>
>
> netpoll_poll()
> poll_napi()
> spin_trylock(&napi->poll_lock)
> poll_one_napi()
> napi->poll() := sky2_poll()
> napi_complete()
> local_irq_disable()
> local_irq_enable() <--- *BUG*
>
> <irq>
> irq_exit()
> do_softirq()
> net_rx_action()
> spin_lock(&napi->poll_lock) <--- Deadlock!
>
> Because we still hold the lock....

Yep, that will deadlock.

Can some test if using local_irq_{save,restore}() in
napi_complete() cures this lockdep warning?

Thanks.


\
 
 \ /
  Last update: 2008-03-27 12:07    [W:1.061 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site