lkml.org 
[lkml]   [2008]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Bugme-new] [Bug 10326] New: inconsistent lock state in net_rx_action
    On Thu, Mar 27, 2008 at 11:56:19AM +0100, Peter Zijlstra wrote:
    > On Thu, 2008-03-27 at 02:18 -0700, Andrew Morton wrote:
    ...
    > > I bet the net code is wrong and we missed it ;)

    It looks like you are natural born winner! Congratulations!

    > How about this:
    >
    > <irqs disabled>
    >
    > netpoll_poll()
    > poll_napi()
    > spin_trylock(&napi->poll_lock)
    > poll_one_napi()
    > napi->poll() := sky2_poll()
    > napi_complete()
    > local_irq_disable()
    > local_irq_enable() <--- *BUG*

    Yes! I missed it's unconditional here... Great catch!

    On the other hand, still a question why lockdep doesn't see this
    every day?

    Jarek P.


    \
     
     \ /
      Last update: 2008-03-27 13:19    [W:0.034 / U:60.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site