Messages in this thread | | | Date | Mon, 11 Feb 2008 19:09:55 +0100 | From | Marcin Slusarz <> | Subject | Re: bug in checkpatch (on pointers to typedefs?) |
| |
On Mon, Feb 11, 2008 at 10:23:39AM +0000, Andy Whitcroft wrote: > On Sun, Feb 10, 2008 at 03:33:02PM +0100, Marcin Slusarz wrote: > > Hi > > > > Checkpatch in current mainline outputs following errors: > > > > $ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c > > ERROR: need consistent spacing around '*' (ctx:WxV) > > #205: FILE: fs/udf/misc.c:205: > > + tag *tag_p; > > ^ > > > > $ ./scripts/checkpatch.pl -q --file ./fs/udf/unicode.c > > ERROR: need consistent spacing around '*' (ctx:WxV) > > #48: FILE: fs/udf/unicode.c:48: > > +int udf_build_ustr(struct ustr *dest, dstring *ptr, int size) > > ^ > > (...) > > > > I think the code is ok. > > Yep the code is clearly correct. Can I have the whole patch fragment > you got these against so I can figure out why we are unable to detect > these two as types, I would expect us to have done so. Also what > version of checkpatch is this? There is a version string at the top. It's current Linus git tree (both checkpatch and "testcase").
Marcin
| |