Messages in this thread | | | Date | Thu, 14 Feb 2008 19:29:16 +0100 (CET) | From | Jan Engelhardt <> | Subject | Re: bug in checkpatch (on pointers to typedefs?) |
| |
On Feb 14 2008 10:06, Andy Whitcroft wrote: >On Wed, Feb 13, 2008 at 08:43:58PM +0100, Jan Engelhardt wrote: >> >> On Feb 10 2008 15:33, Marcin Slusarz wrote: >> >Checkpatch in current mainline outputs following errors: >> > >> >$ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c >> >ERROR: need consistent spacing around '*' (ctx:WxV) >> >#205: FILE: fs/udf/misc.c:205: >> >+ tag *tag_p; >> > ^ >> >> I'd say "don't add any new typedefs" (and perhaps get rid of old ones). > >It should be doing that at the site of the new typedef :) > Additionally, yes. Given:
typedef struct { ... } tag_t; void foo(void) { tag_t name; }
A user adding
+ tag_t newthing;
could at the same time give the struct a name if it already does not have one and instead use
+ struct tag newthing;
then.
| |