lkml.org 
[lkml]   [2008]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: bug in checkpatch (on pointers to typedefs?)
    I saw this too with checkpatch.pl version 0.12
    It seems like checkpatch.pl knows only about types derived
    from @typeList by build_types.

    Example below...

    Benny

    $ cat <<EOF | scripts/checkpatch.pl -
    Signed-off-by: john@smith.net
    ---
    diff a/f.c b/f.c
    --- a/f.c
    +++ b/f.c
    @@ -1,0 +1,2 @@
    +foo(int a, my_uint32 *);
    +bar(int a, my_uint32_t *);
    EOF
    ERROR: need consistent spacing around '*' (ctx:WxB)
    #7: FILE: f.c:1:
    +foo(int a, my_uint32 *);
    ^
    total: 1 errors, 0 warnings, 2 lines checked

    On Feb. 11, 2008, 12:23 +0200, Andy Whitcroft <apw@shadowen.org> wrote:
    > On Sun, Feb 10, 2008 at 03:33:02PM +0100, Marcin Slusarz wrote:
    >> Hi
    >>
    >> Checkpatch in current mainline outputs following errors:
    >>
    >> $ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c
    >> ERROR: need consistent spacing around '*' (ctx:WxV)
    >> #205: FILE: fs/udf/misc.c:205:
    >> + tag *tag_p;
    >> ^
    >>
    >> $ ./scripts/checkpatch.pl -q --file ./fs/udf/unicode.c
    >> ERROR: need consistent spacing around '*' (ctx:WxV)
    >> #48: FILE: fs/udf/unicode.c:48:
    >> +int udf_build_ustr(struct ustr *dest, dstring *ptr, int size)
    >> ^
    >> (...)
    >>
    >> I think the code is ok.
    >
    > Yep the code is clearly correct. Can I have the whole patch fragment
    > you got these against so I can figure out why we are unable to detect
    > these two as types, I would expect us to have done so. Also what
    > version of checkpatch is this? There is a version string at the top.
    >
    > -apw
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/



    \
     
     \ /
      Last update: 2008-02-11 17:09    [W:0.024 / U:89.380 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site