Messages in this thread Patch in this message | | | From | Benjamin Herrenschmidt <> | Date | Tue, 14 Oct 2008 11:53:05 +1100 | Subject | [PATCH] Fix broken debug output reserve_region_with_split() |
| |
That debug outpout in kernel/resource.c is busted on 32-bit machines, fix it with appropriate casts.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> ---
One day Yinghai will figure out that resource_size_t can be 32-bit and thus as printk arguments must be cast to (unsigned long long) explicitely when using %llx... hopefully, that day, Ingo will also catch these before committing them as it's not the first one like this :-)
kernel/resource.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-work.orig/kernel/resource.c 2008-10-14 11:48:31.000000000 +1100 +++ linux-work/kernel/resource.c 2008-10-14 11:48:50.000000000 +1100 @@ -550,8 +550,9 @@ static void __init __reserve_region_with if (!res) { printk(KERN_DEBUG " __reserve_region_with_split: (%s) [%llx, %llx], res: (%s) [%llx, %llx]\n", - conflict->name, conflict->start, conflict->end, - name, start, end); + conflict->name, (unsigned long long)conflict->start, + (unsigned long long)conflict->end, + name, (unsigned long long)start, (unsigned long long)end); /* failed, split and try again */
| |