Messages in this thread | | | Subject | Re: [PATCH] Fix broken debug output reserve_region_with_split() | From | Benjamin Herrenschmidt <> | Date | Tue, 14 Oct 2008 12:41:27 +1100 |
| |
On Mon, 2008-10-13 at 18:04 -0700, H. Peter Anvin wrote: > Benjamin Herrenschmidt wrote: > > That debug outpout in kernel/resource.c is busted on 32-bit > > machines, fix it with appropriate casts. > > > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > --- > > > > One day Yinghai will figure out that resource_size_t can be 32-bit > > and thus as printk arguments must be cast to (unsigned long long) > > explicitely when using %llx... hopefully, that day, Ingo will also > > catch these before committing them as it's not the first one like > > this :-) > > > > I really think Linus' solution (add a resource printf modifier, that can > contain the whole format) is much better.
I agree. In fact I may even have a patch somewhere for that.
It has to be a pointer tho, thus what do we want ? Something that takes a pointer to a resource_size_t or to a whole struct resource ? In the later case, do we want to print the whole flags too ?
Cheers, Ben.
| |