Messages in this thread Patch in this message | | | Date | Fri, 04 Jan 2008 13:53:05 +0800 | From | Li Zefan <> | Subject | [PATCH 5/5] CONNECTOR: return proper error code in cn_call_callback() |
| |
Error code should be set to EINVAL instead of ENODEV if !queue_work(). There's another call of queue_work() which may set err to EINVAL.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
--- drivers/connector/connector.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c index 865303b..37976dc 100644 --- a/drivers/connector/connector.c +++ b/drivers/connector/connector.c @@ -146,6 +146,8 @@ static int cn_call_callback(struct cn_msg *msg, void (*destruct_data)(void *), v if (queue_work(dev->cbdev->cn_queue, &__cbq->work)) err = 0; + else + err = -EINVAL; } else { struct cn_callback_data *d; -- 1.5.3.rc7
| |