Messages in this thread | | | Date | Sat, 5 Jan 2008 18:24:49 +0300 | From | Evgeniy Polyakov <> | Subject | Re: [PATCH 5/5] CONNECTOR: return proper error code in cn_call_callback() |
| |
Hi.
Sorry for long reply.
On Fri, Jan 04, 2008 at 01:51:25AM -0800, David Miller (davem@davemloft.net) wrote: > > Error code should be set to EINVAL instead of ENODEV if !queue_work(). > > There's another call of queue_work() which may set err to EINVAL. > > > > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> > > This one is a bug fix so I'll apply it to net-2.6 and push > to Linus. > > The rest are cleanups which I'll queue up for 2.6.25
Although I'm not sure changing error from nodev to inval is a bug fix :), I have no problem with pushing it first. Loop above will break out after first matched id, so it will never call the path, which can change error, again.
Thanks a lot for patches and quick merge!
-- Evgeniy Polyakov
| |