lkml.org 
[lkml]   [2007]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 2/9] lguest: the guest code
From
Date
On Wed, 2007-05-09 at 13:16 +0300, Pekka Enberg wrote:
> Hi Rusty,
>
> On 5/9/07, akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
> > +static void add_lguest_device(unsigned int index)
> > +{
> > + struct lguest_device *new;
> > +
> > + lguest_devices[index].status |= LGUEST_DEVICE_S_ACKNOWLEDGE;
> > + new = kmalloc(sizeof(struct lguest_device), GFP_KERNEL);
> > + if (!new) {
> > + printk(KERN_EMERG "Cannot allocate lguest device %u\n", index);
> > + lguest_devices[index].status |= LGUEST_DEVICE_S_FAILED;
>
> [snip]
>
> Any reason why we don't return an error here?

Hi Pekka,

Hmm, where would the error go?

A little confused,
Rusty.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-09 14:03    [W:0.045 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site