Messages in this thread | | | Date | Wed, 9 May 2007 13:16:23 +0300 | From | "Pekka Enberg" <> | Subject | Re: [patch 2/9] lguest: the guest code |
| |
Hi Rusty,
On 5/9/07, akpm@linux-foundation.org <akpm@linux-foundation.org> wrote: > +static void add_lguest_device(unsigned int index) > +{ > + struct lguest_device *new; > + > + lguest_devices[index].status |= LGUEST_DEVICE_S_ACKNOWLEDGE; > + new = kmalloc(sizeof(struct lguest_device), GFP_KERNEL); > + if (!new) { > + printk(KERN_EMERG "Cannot allocate lguest device %u\n", index); > + lguest_devices[index].status |= LGUEST_DEVICE_S_FAILED;
[snip]
Any reason why we don't return an error here? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |