Messages in this thread | | | Date | Sun, 27 May 2007 17:18:17 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] add a trivial patch style checker |
| |
On Sun, 27 May 2007 18:11:25 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
> +#gotos aren't indented > + if($line=~/^\s*[A-Za-z\d_]+:/ and !($line=~/^\s*default:/)){ > + print "Gotos should not be indented\n"; > + print "$herecurr"; > + $clean = 0; > + }
This should be "labels". Plus a lot of people do indent the labels by a single space to avoid confusing `diff -p', which seems a reasonable thing to not complain about. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |