lkml.org 
[lkml]   [2007]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] add a trivial patch style checker II
    > Yeah, that is a very sensible idea.
    >
    > > Possible further checks that might make sense:
    > > - panic() anywhere in drivers/*
    > > - externs in .c files without asmlinkage
    > > - general checking that everything in a fully visible {} block is the right
    > > indentation
    > >

    Here are some more warnings I would like to see:

    - Warning for any spinlock/mutex definition that doesn't have a comment
    nearby (all locks ought to be documented)
    - Keep an ifdef count and give minus points for too many
    - Warn about any architecture ifdefs (__i386__ etc.)
    While not 100% illegal this is definitely something that needs to be
    justified

    -Andi

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-31 14:11    [W:0.021 / U:0.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site