lkml.org 
[lkml]   [2007]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] driver core: fix warning of temporarily unused multithreaded probing function (was: Re: Linux 2.6.22-rc1)
On Sun, 13 May 2007 11:47:53 +0200,
Borislav Petkov <bbpetkov@yahoo.de> wrote:

> if I'm not mistaken, despite the PCI_MULTITHREAD_PROBE removal,
> Cornelia Huck wanted to keep driver-core-per-subsystem-multithreaded-probing.patch:
>
> <quote>
> > Wouldn't per-subsystem multithreaded probing just expose bugs that
> > could also be exposed on SMP systems?
>
> Yes, it would be the same.
> </quote>

Hm, I don't think I'll follow up with this - we need a different
approach, I guess.

> However, device_probe_drivers() remains temporarily unused, so we either
> suppress the compiler warning or remove the whole function altogether. The
> following patch does the first.

I'd prefer to kill device_probe_drivers(). If we really need something
like this sometime in the future, we can easily resurrect it.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>

---
drivers/base/dd.c | 13 -------------
1 file changed, 13 deletions(-)

--- linux-2.6.orig/drivers/base/dd.c
+++ linux-2.6/drivers/base/dd.c
@@ -207,19 +207,6 @@ static int __device_attach(struct device
return driver_probe_device(drv, dev);
}

-static int device_probe_drivers(void *data)
-{
- struct device *dev = data;
- int ret = 0;
-
- if (dev->bus) {
- down(&dev->sem);
- ret = bus_for_each_drv(dev->bus, NULL, dev, __device_attach);
- up(&dev->sem);
- }
- return ret;
-}
-
/**
* device_attach - try to attach device to a driver.
* @dev: device.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2007-05-14 10:09    [W:0.318 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site