lkml.org 
[lkml]   [2007]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] high-res timers: UP resume fix
From
Date
On Sat, 2007-04-07 at 11:47 +0200, Ingo Molnar wrote:
> * Rafael J. Wysocki <rjw@sisk.pl> wrote:
>
> > > We do in on_each_cpu() unconditionally. I missed that.
> >
> > BTW, the on_each_cpu() in clock_was_set() is unnecessary, because
> > timekeeping_resume() is always run on one CPU.
>
> yes - but that's not the only place where we do clock_was_set(), and the
> on_each_cpu() is necessary in every other case. So i think the right
> solution was the patch i did: to split the resume functionality from the
> clock_was_set() functionality.

Right, I reused it and just did not notice, that interrupts are enabled
unconditionally in on_each_cpu().

tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-07 11:53    [W:0.111 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site